Skip to content

emacsPackages.jq-mode: patch in jq program#391808

Merged
jian-lin merged 1 commit intoNixOS:masterfrom
nagy:emacs-jq
Mar 21, 2025
Merged

emacsPackages.jq-mode: patch in jq program#391808
jian-lin merged 1 commit intoNixOS:masterfrom
nagy:emacs-jq

Conversation

@nagy
Copy link
Member

@nagy nagy commented Mar 21, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: emacs Text editor label Mar 21, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 21, 2025
Copy link
Contributor

@jian-lin jian-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@jian-lin
Copy link
Contributor

I know that melpa-packages.nix is not sorted. However, we try to keep the tail of that file sorted. Could you move jq-mode here?

@nagy
Copy link
Member Author

nagy commented Mar 21, 2025

done

@jian-lin jian-lin merged commit 88087e2 into NixOS:master Mar 21, 2025
23 of 27 checks passed
@nagy nagy deleted the emacs-jq branch March 21, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: emacs Text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments